Skip to content

Delete user-project mappings on project deletion#13456

Open
Tonitzpp wants to merge 1 commit into
apache:4.20from
scclouds:delete-account-from-deleted-project
Open

Delete user-project mappings on project deletion#13456
Tonitzpp wants to merge 1 commit into
apache:4.20from
scclouds:delete-account-from-deleted-project

Conversation

@Tonitzpp

@Tonitzpp Tonitzpp commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Description

When a user is added to a project, and this project is then deleted, the user-project mapping is never removed from the database. Thus, when attempting to delete the user's account, an error is returned stating that the account is still linked to a project.

Therefore, this PR deletes the invalid user-project mappings and fixes the project deletion process in CloudStack.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

  1. A new project belonging to a domain admin account was created and a user was added to it.
  2. In the database, I observed that select * from project_account had the entries for 1 account and 1 user belonging to the project.
  3. I deleted the project.
  4. I the database, using the same command, I observed that the mappings were removed after project deletion.
  5. I deleted the user's account without receiving any errors.

@Tonitzpp Tonitzpp mentioned this pull request Jun 19, 2026
Open
2 tasks
@codecov

codecov Bot commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.26%. Comparing base (b26b70c) to head (0c297c1).
⚠️ Report is 4 commits behind head on 4.20.

Files with missing lines Patch % Lines
...ava/com/cloud/upgrade/dao/Upgrade42030to42040.java 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #13456   +/-   ##
=========================================
  Coverage     16.25%   16.26%           
- Complexity    13432    13437    +5     
=========================================
  Files          5667     5667           
  Lines        500670   500673    +3     
  Branches      60801    60802    +1     
=========================================
+ Hits          81401    81417   +16     
+ Misses       410163   410148   -15     
- Partials       9106     9108    +2
Flag Coverage Δ
uitests 4.14% <ø> (ø)
unittests 17.11% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Tonitzpp Tonitzpp force-pushed the delete-account-from-deleted-project branch from ac25417 to 4244c2c Compare June 19, 2026 13:38
@Tonitzpp Tonitzpp force-pushed the delete-account-from-deleted-project branch from 4244c2c to 2106a39 Compare June 19, 2026 13:43
@Tonitzpp Tonitzpp changed the base branch from main to 4.20 June 19, 2026 13:43
@Tonitzpp Tonitzpp force-pushed the delete-account-from-deleted-project branch from 2106a39 to 0c297c1 Compare June 19, 2026 13:45
@winterhazel

winterhazel commented Jun 19, 2026

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Jun 19, 2026

Copy link
Copy Markdown

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jun 19, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18316

@DaanHoogland DaanHoogland modified the milestones: 4.24.0, 4.20.4 Jun 21, 2026
@DaanHoogland

DaanHoogland commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

looks good, but will need extensive upgrade testing (will 20.2 -> 23.0 work?)

@Tonitzpp Tonitzpp changed the title fix in issue: delete an account belonging to a deleted project Delete an account belonging to a deleted project Jun 22, 2026
@Tonitzpp Tonitzpp changed the title Delete an account belonging to a deleted project Delete user-project mappings on project deletion Jun 22, 2026
@weizhouapache

weizhouapache commented Jun 25, 2026

Copy link
Copy Markdown
Member

@Tonitzpp
I am able to reproduce the issue #12601

I do not think this PR fixes it, as listAdministratedProjectIds is used to get the project accounts, which uses AdminSearch , not ProjectAccountSearch

cc @harikrishna-patnala @DaanHoogland

@weizhouapache

weizhouapache commented Jun 30, 2026

Copy link
Copy Markdown
Member

@Tonitzpp
could you please address the comment if you have time ?
it would be great if you can verify the changes too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.20.4

Development

Successfully merging this pull request may close these issues.

5 participants

@Tonitzpp @winterhazel @blueorangutan @DaanHoogland @weizhouapache